Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple pagination #73

Merged
merged 5 commits into from
Jul 22, 2021
Merged

Add simple pagination #73

merged 5 commits into from
Jul 22, 2021

Conversation

Saibamen
Copy link
Contributor

Ugly but works™

Related: #21

@Saibamen Saibamen mentioned this pull request Jul 18, 2021
Merged
@Saibamen
Copy link
Contributor Author

Saibamen commented Jul 18, 2021 •
edited
Loading

@louislam: I'm not familiar with Vue.

After merging, you need to:

  1. Create component/helper for pagination - right now logic is duplicated. This will also help to add settings change in frontend in the future.
  2. Add "pagination" to database select queries

@louislam louislam added the feature-request Request for new features to be added label Jul 20, 2021
@louislam louislam added this to the 1.0.7 milestone Jul 20, 2021
@louislam louislam merged commit afd4cf2 into louislam:master Jul 22, 2021
@Saibamen Saibamen deleted the simple_pagination branch July 22, 2021 07:22
@snyk-bot snyk-bot mentioned this pull request Feb 9, 2023
Merged
@jjschwarz jjschwarz mentioned this pull request Sep 24, 2023
Closed
2 tasks
@Blue-Gamer48 Blue-Gamer48 mentioned this pull request Nov 24, 2023
Open
@lsx1205 lsx1205 mentioned this pull request Oct 25, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature-request Request for new features to be added
Projects
None yet
Milestone
1.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Saibamen @louislam